Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): build_test PR command #1599

Merged
merged 4 commits into from
Aug 24, 2023
Merged

feat(ci): build_test PR command #1599

merged 4 commits into from
Aug 24, 2023

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Jul 27, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #1584

@mwangggg mwangggg added feat New feature or request safe-to-test labels Jul 27, 2023
@maxcao13
Copy link
Member

/build_test

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-2e5d25f6bd062b6c99d35f62bf18e196b08301d1-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-2e5d25f6bd062b6c99d35f62bf18e196b08301d1-linux-arm64 sh smoketest.sh

@mwangggg mwangggg force-pushed the gh_pr branch 2 times, most recently from 1772b34 to 458e749 Compare July 27, 2023 18:02
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-458e749cf01a50af69c6d80879861eea1235122f-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-458e749cf01a50af69c6d80879861eea1235122f-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-db875c63baa43ed4fc0904b3d7d68cda790f8b1c-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-db875c63baa43ed4fc0904b3d7d68cda790f8b1c-linux-amd64 sh smoketest.sh

@mwangggg mwangggg force-pushed the gh_pr branch 2 times, most recently from b7a7f48 to 3c9d165 Compare July 27, 2023 19:19
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-b7a7f48332464c50885b44d4dbfee7f206bbc1ae-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-b7a7f48332464c50885b44d4dbfee7f206bbc1ae-linux-arm64 sh smoketest.sh

@mwangggg mwangggg force-pushed the gh_pr branch 3 times, most recently from 0ac4579 to be4aac7 Compare July 27, 2023 19:30
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-be4aac746fbe053ad19765422b4f67dfe8fa366f-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-be4aac746fbe053ad19765422b4f67dfe8fa366f-linux-arm64 sh smoketest.sh

@mwangggg
Copy link
Member Author

/build_test

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-52d27ca8485b0f32044cd8800962fc013dcbd87a-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-52d27ca8485b0f32044cd8800962fc013dcbd87a-linux-arm64 sh smoketest.sh

@mwangggg mwangggg force-pushed the gh_pr branch 2 times, most recently from ea76307 to a461f2b Compare July 27, 2023 20:13
@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-a461f2b2f88dc55aad1e3afa286161d659005817-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-a461f2b2f88dc55aad1e3afa286161d659005817-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-b0d65e9583428bf49877737643295add4c36fc1e-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-b0d65e9583428bf49877737643295add4c36fc1e-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-e82ff12eb45ebe2644e21ed34e93efdf30558b45-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-e82ff12eb45ebe2644e21ed34e93efdf30558b45-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-7bc68babb87ac47a26981faa534a2325655f272c-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-7bc68babb87ac47a26981faa534a2325655f272c-linux-amd64 sh smoketest.sh

@andrewazores
Copy link
Member

Changes look like they make sense, but reading Actions YAML is always a pain. Sample run, please?

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-0544a73b683553fd0686373a7f03fe11a48a9613-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-0544a73b683553fd0686373a7f03fe11a48a9613-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-5f58c107850d0080ec1836f4bb157703789f6f3f-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-5f58c107850d0080ec1836f4bb157703789f6f3f-linux-amd64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-6232387c16bde09877804e48ca6ade92f33c47c5-linux-arm64 sh smoketest.sh

@github-actions
Copy link
Contributor

Test image available:

$ CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat:pr-1599-6232387c16bde09877804e48ca6ade92f33c47c5-linux-amd64 sh smoketest.sh

@andrewazores
Copy link
Member

Any other review comments?

maxcao13
maxcao13 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work on this!

@andrewazores andrewazores merged commit 7009f1c into cryostatio:main Aug 24, 2023
19 checks passed
@andrewazores andrewazores mentioned this pull request Aug 24, 2023
Closed
@tthvo tthvo mentioned this pull request Aug 25, 2023
Merged
7 tasks
@mwangggg mwangggg mentioned this pull request Aug 29, 2023
Merged
7 tasks
andrewazores pushed a commit that referenced this pull request Sep 13, 2023
@mwangggg @andrewazores
feat(ci): build_test PR command (#1599)
9c4b777
@mwangggg mwangggg deleted the gh_pr branch March 12, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo left review comments

@maxcao13 maxcao13 maxcao13 approved these changes

@andrewazores andrewazores andrewazores approved these changes

@mergify mergify[bot] mergify[bot] left review comments

@aali309 aali309 Awaiting requested review from aali309

Assignees
No one assigned
Labels
feat New feature or request safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Implement PR command /build_test
4 participants
@mwangggg @maxcao13 @tthvo @andrewazores