-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(version): prepare for 2.4.1 development #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a v2.4.1-dev tag on the Cryostat repo to fix this test
I guess there needs to be a new snapshot build of the Cryostat container so that it picks that tag up and uses that in the health response. I just created a new tag pointing at an existing commit, so there was no new push and no CI run. |
Maybe we want to apply that pretty generally to most/all of our CI actions - if it is triggered by a push to some branch(es), it should also be triggered by tags being pushed? |
I did something like this, but my regex was too restrictive: Perhaps it should just be: on:
push:
tags: if that's valid syntax. |
I don't think it's totally clear here: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore It says that this "accepts" glob patterns, so they might be optional, but it doesn't explicitly say and there are no examples without provided patterns. |
The regex is optional according to this: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#patterns-to-match-branches-and-tags |
Cryostat 2.4.1-snapshot upstream image is finally up on quay. $ https :8181/health
HTTP/1.1 200 OK
content-encoding: gzip
content-length: 139
content-type: application/json
{
"cryostatVersion": "v2.4.1-dev-5-gd5f181d0",
"dashboardAvailable": false,
"dashboardConfigured": false,
"datasourceAvailable": false,
"datasourceConfigured": false,
"reportsAvailable": true,
"reportsConfigured": false
} |
Related to cryostatio/cryostat#1695