Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(version): prepare for 2.4.1 development #109

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Dec 8, 2023

Related to cryostatio/cryostat#1695

@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Dec 8, 2023
@mergify mergify bot added the safe-to-test label Dec 8, 2023
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a v2.4.1-dev tag on the Cryostat repo to fix this test

@andrewazores
Copy link
Member Author

@andrewazores
Copy link
Member Author

andrewazores commented Dec 8, 2023

I guess there needs to be a new snapshot build of the Cryostat container so that it picks that tag up and uses that in the health response. I just created a new tag pointing at an existing commit, so there was no new push and no CI run.

@andrewazores
Copy link
Member Author

Maybe we want to apply that pretty generally to most/all of our CI actions - if it is triggered by a push to some branch(es), it should also be triggered by tags being pushed?

@ebaron
Copy link
Member

ebaron commented Dec 8, 2023

Maybe we want to apply that pretty generally to most/all of our CI actions - if it is triggered by a push to some branch(es), it should also be triggered by tags being pushed?

I did something like this, but my regex was too restrictive:
https://github.com/cryostatio/cryostat/blob/af1d386b54380d57744af4f4e270432ef78e33fc/.github/workflows/push-ci.yml#L15

Perhaps it should just be:

on:
  push:
    tags:

if that's valid syntax.

@andrewazores
Copy link
Member Author

I don't think it's totally clear here: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore

It says that this "accepts" glob patterns, so they might be optional, but it doesn't explicitly say and there are no examples without provided patterns.

@ebaron
Copy link
Member

ebaron commented Dec 8, 2023

@andrewazores
Copy link
Member Author

Cryostat 2.4.1-snapshot upstream image is finally up on quay.

$ https :8181/health
HTTP/1.1 200 OK
content-encoding: gzip
content-length: 139
content-type: application/json

{
    "cryostatVersion": "v2.4.1-dev-5-gd5f181d0",
    "dashboardAvailable": false,
    "dashboardConfigured": false,
    "datasourceAvailable": false,
    "datasourceConfigured": false,
    "reportsAvailable": true,
    "reportsConfigured": false
}

@ebaron ebaron merged commit cc58b41 into cryostatio:cryostat-v2.4 Dec 8, 2023
6 of 8 checks passed
@andrewazores andrewazores deleted the prepare-241 branch December 8, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants