feat(diagnostics): Add API handler for invoking GC #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
reviewed
Oct 1, 2024
Signed-off-by: Andrew Azores <me@andrewazor.es>
andrewazores
reviewed
Oct 1, 2024
There was a problem hiding this comment.
- feat(diagnostics): Add API handler for invoking GC #492
- feat(diagnostic): implement diagnostics class with gc invocation operation cryostat#644
- feat(diagnostic): add interface method for invoking MBean operations cryostat-core#459
- feat(diagnostics): Add Dashboard card for invoking diagnostic operations cryostat-web#1426
all seem to be working well when tested together. The UI needs a bit of tweaking so I'll hold off approving/merging the backend pieces for now, but I think they are all OK.
andrewazores
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Related to cryostatio/cryostat#133
Adds an API handler to invoke GC on a target through the Memory MBean.
Opening as Draft while I adjust it to the approach/endpoint expected by cryostatio/cryostat#644