-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server abstraction #30
Open
darnfish
wants to merge
11
commits into
master
Choose a base branch
from
server-abstraction
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2019
Here's a to-do list of things to do before this can be merged:
I'll add to this if anything else pops into mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature now adds an abstraction between a VM instance and a Portal
@cryb/portal
)Here's how the flow of things works now:
@cryb/portals
over WebSocket and verifies itself using a signed JWT token with a common secret@cryb/api
, a check is made to see if there is a server/VM available. If there is, it's automatically assigned.This change comes with some major benefits:
--portalId
anymore as that's handled automatically.NoPortalFound
errorsThere's also an option to dynamically spawn VM instances to be added to the pool when Portals runs out of instances that are currently connected. This will use the Driver format.
Let me know what you think! There are several other pull requests in the following repositories which need to be merged at the same time as this PR:
@cryb/api
@cryb/portal
@cryb/aperture