Use generic media control commands #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For TUNER, maps onto the same commands in the end, but now supports also other sources.
crowbarz
requested changes
Nov 27, 2024
| if pioneer.source.get(self.zone) == SOURCE_TUNER: | ||
| features |= MediaPlayerEntityFeature.PREVIOUS_TRACK | ||
| features |= MediaPlayerEntityFeature.NEXT_TRACK | ||
| control_commands = pioneer.get_supported_media_controls(self.zone) |
There was a problem hiding this comment.
This section needs to be conditional on the currently active source supporting media controls. As it stands, this code removes the capability of using previous/next track when the tuner is active.
| async def async_media_previous_track(self) -> None: | ||
| """Send previous track command.""" | ||
|
|
||
| async def tuner_previous_preset() -> None: | ||
| await self.pioneer.tuner_previous_preset() | ||
| async def media_previous_track() -> None: |
There was a problem hiding this comment.
The media_previous_track and media_next_track methods need to execute the media control commands conditional on the currently active source supporting media controls, without removing the ability to change between tuner presets when the tuner is the active source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For TUNER, maps onto the same commands in the end, but now supports also other sources.