feat(dataplex): add aspect_type resource #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nilan3 <nilanthanb1994@gmail.com>
nilan3
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
|
/test-examples="examples/dataplex/v1beta1/aspecttype.yaml" |
turkenf
reviewed
Nov 29, 2024
| @@ -430,6 +430,8 @@ var terraformPluginSDKExternalNameConfigs = map[string]config.ExternalName{ | |||
| "google_dataplex_asset": config.TemplatedStringAsIdentifier("name", "projects/{{ .setup.configuration.project }}/locations/{{ .parameters.location }}/lakes/{{ .parameters.lake }}/zones/{{ .parameters.dataplex_zone }}/assets/{{ .external_name }}"), | |||
| // Imported by using the following projects/{{project}}/locations/{{location}}/lakes/{{lake}}/zones/{{name}} | |||
| "google_dataplex_zone": config.TemplatedStringAsIdentifier("name", "projects/{{ .setup.configuration.project }}/locations/{{ .parameters.location }}/lakes/{{ .parameters.lake }}/zones/{{ .external_name }}"), | |||
| // Imported by using the following projects/{{project}}/locations/{{location}}/aspectTypes/{{aspect_type_id}} | |||
| "google_dataplex_aspect_type": config.IdentifierFromProvider, | |||
There was a problem hiding this comment.
For external name normalization, could you please try the following TemplatedStringAsIdentifier configuration? If it works, please mark the location parameter as required as shown here.
Suggested change
| "google_dataplex_aspect_type": config.IdentifierFromProvider, | |
| "google_dataplex_aspect_type": TemplatedStringAsIdentifier("aspect_type_id", "projects/{{ .setup.configuration.project }}/locations/{{ .parameters.location }}/aspectTypes/{{ .external_name }}"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add resources for the following terraform resources:
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
UPTEST_EXAMPLE_LIST="examples/dataplex/v1beta1/aspecttype.yaml"
--- PASS: kuttl (45.11s) --- PASS: kuttl/harness (0.00s) --- PASS: kuttl/harness/case (44.02s) PASS 10:54:19 [ OK ] running automated tests