feat: added authnmapping resource #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Kerwood <patrick@kerwood.dk>
ytsarev
approved these changes
Oct 19, 2022
|
@Kerwood sorry, I am not actively monitoring this repo. Could you resolve the conflicts? After the force-push could you please ping me for the merge ? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Kerwood patrick@kerwood.dk
Description of your changes
Added support for SAML group mappings.
This PR is currently a draft because of a bug in the DataDog Go library described here: DataDog/terraform-provider-datadog#1335
A fix to this would be to upgrade the datadog Terraform provider from
3.12.0to3.14.0, but that is not possible because of thesyntheticsresource having a sensitive integer field which is currently not supported be terrajet. An approval of this PR will fix that. crossplane/terrajet#290I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
With love ❤️.. And a local k8s cluster creating the group mapping in DD.