[#1548] Use CurrentAttributes to replace current_user with Current.user #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astronaut-wannabe
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1548
How does this pull request make you feel (in animated GIF format)?
🎉
What are the relevant GitHub issues?
resolves #1548
What does this pull request do?
Current.userfrom the sessionCurrent.usereverywhere instead ofcurrent_userHow should this be manually tested?
Sign in and it should work.
Is there any background context you want to provide for reviewers?
Whenever we can use the framework itself and create/maintain less ourselves, the better.
Questions for the pull request author (delete any that don't apply):