Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of Model hierarchy to Kotlin #1457

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JPercival
Copy link
Contributor

  • Model and ModelImporter

Copy link

This Pull Request has failed the formatting check

Please run gradlew spotlessApply to fix the formatting issues.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 59.35335% with 176 lines in your changes missing coverage. Please review.

Project coverage is 65.91%. Comparing base (e9b4887) to head (f058a1e).

Files with missing lines Patch % Lines
...org/cqframework/cql/cql2elm/model/ModelImporter.kt 54.84% 125 Missing and 38 partials ⚠️
...in/java/org/cqframework/cql/cql2elm/model/Model.kt 83.01% 4 Missing and 5 partials ⚠️
.../src/main/java/org/hl7/cql/model/Relationship.java 0.00% 3 Missing ⚠️
...a/org/cqframework/cql/cql2elm/model/SystemModel.kt 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1457      +/-   ##
============================================
+ Coverage     65.86%   65.91%   +0.04%     
- Complexity     2438     2524      +86     
============================================
  Files           487      487              
  Lines         28599    28582      -17     
  Branches       5497     5498       +1     
============================================
+ Hits          18836    18839       +3     
+ Misses         7536     7517      -19     
+ Partials       2227     2226       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
64.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant