Skip to content

Commit

Permalink
Remove redundant 'static' from objects that already have internal lin…
Browse files Browse the repository at this point in the history
…kage
  • Loading branch information
jwakely committed Nov 4, 2024
1 parent 1876660 commit bb7b2d5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions src/report_generator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,13 @@ auto utc_timestamp() -> std::tm const & {
}

// global data - would like to do something about that.
static std::string const build_timestamp{format_time("Revised %Y-%m-%d at %H:%M:%S UTC\n", utc_timestamp())};
std::string const build_timestamp{format_time("Revised %Y-%m-%d at %H:%M:%S UTC\n", utc_timestamp())};

static std::string const maintainer_email{"lwgchair@gmail.com"};
std::string const maintainer_email{"lwgchair@gmail.com"};

static std::string const maintainer_name{"Jonathan Wakely"};
std::string const maintainer_name{"Jonathan Wakely"};

static std::string const is14882_docno{"ISO/IEC IS 14882:2024(E)"};
std::string const is14882_docno{"ISO/IEC IS 14882:2024(E)"};

struct order_by_first_tag {
bool operator()(lwg::issue const & x, lwg::issue const & y) const noexcept {
Expand Down
6 changes: 3 additions & 3 deletions src/status.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
#include <algorithm>

namespace {
static constexpr char const * LWG_ACTIVE {"lwg-active.html" };
static constexpr char const * LWG_CLOSED {"lwg-closed.html" };
static constexpr char const * LWG_DEFECTS{"lwg-defects.html"};
constexpr char const * LWG_ACTIVE {"lwg-active.html" };
constexpr char const * LWG_CLOSED {"lwg-closed.html" };
constexpr char const * LWG_DEFECTS{"lwg-defects.html"};
}

auto lwg::filename_for_status(std::string_view stat) -> std::string_view {
Expand Down

0 comments on commit bb7b2d5

Please sign in to comment.