Use 401 Unauthorized for bad bearer tokens #3173
Draft
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is breaking change! We will now use 401 instead of 400 as the HTTP code for the response when a bearer token in the request is invalid (expired for example). See RFC 6750.
nono
added a commit
to cozy/cozy-client-js
that referenced
this pull request
Oct 4, 2021
The stack will change the http code used for expired tokens from 400 to 401. This change will allow cozy-client-js to try refreshing the token in such cases. See cozy/cozy-stack#3173
nono
added a commit
to cozy/cozy-client
that referenced
this pull request
Oct 4, 2021
The stack will change the http code used for expired tokens from 400 to 401. This change will allow cozy-client to try refreshing the token in such cases. See cozy/cozy-stack#3173
nono
added a commit
to cozy/cozy-client
that referenced
this pull request
Oct 25, 2021
The stack will change the http code used for expired tokens from 400 to 401. This change will allow cozy-client to try refreshing the token in such cases. See cozy/cozy-stack#3173
nono
added a commit
to cozy/cozy-client-js
that referenced
this pull request
Oct 25, 2021
The stack will change the http code used for expired tokens from 400 to 401. This change will allow cozy-client-js to try refreshing the token in such cases. See cozy/cozy-stack#3173
|
@Crash-- ping, what is the status for this PR? |
|
Ping @Crash-- |
1 similar comment
|
Ping @Crash-- |
|
I think we can merge this one now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking change! We will now use 401 instead of 400 as the HTTP
code for the response when a bearer token in the request is invalid
(expired for example). See RFC 6750.
This is a draft pull request, not to be merged yet, as we want to give time to clients to test it and update their code if needed.