[VER-355] feat: Remove Profiles concept
#124
Open
+71
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Ldoppea
force-pushed
the
feat/disable_profiles
branch
from
9734bf4
to
2304954
Compare
We want to remove the concept of `Profiles` as they overlap with Cozy's `Contacts` In cozy-keys-browser we will add the concept of `Contacts` to replace old profiles, but in cozy-pass-web we don't need to do this as the `cozy-contact` app already exists This commit prevents from creating a `Profile` cipher Related PR: cozy/cozy-keys-browser#169
We want to remove the concept of `Profiles` as they overlap with Cozy's `Contacts` In cozy-keys-browser we will add the concept of `Contacts` to replace old profiles, but in cozy-pass-web we don't need to do this as the `cozy-contact` app already exists This commit prevents from restoring `Profile` ciphers Related PR: cozy/cozy-keys-browser#169
We want to remove the concept of `Profiles` as they overlap with Cozy's `Contacts` In cozy-keys-browser we will add the concept of `Contacts` to replace old profiles, but in cozy-pass-web we don't need to do this as the `cozy-contact` app already exists This commit hides the `Profile` category if empty (which should be the case after the migration is done on cozy-keys-browser side) Related PR: cozy/cozy-keys-browser#169
Ldoppea
force-pushed
the
feat/disable_profiles
branch
from
2304954
to
63b32ac
Compare
Ldoppea
changed the title
Profiles conceptProfiles concept
zatteo
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to remove the concept of
Profilesas they overlap with Cozy'sContactsIn cozy-keys-browser we will add the concept of
Contactsto replace old profiles, but in cozy-pass-web we don't need to do this as thecozy-contactapp already existsThis PR only prevent from using
Profilesin the apps, but it does not do any migration process. This will be done on cozy-keys-browser sideRelated PR: cozy/cozy-keys-browser#169
Related PR: cozy/cozy-pass-mobile#96