Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpaca.cow #33

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Add alpaca.cow #33

merged 1 commit into from
Nov 7, 2022

Conversation

mai-space
Copy link
Contributor

The second time is the charm!

But I like alpacas even more.
If you agree, let's merge!

I got the Alpaca face from here.
And the inspiration for the whole art from here.
But I created the art myself.

Thank you for your advice. I have changed my repo accordingly.

Regarding your questions about enhancing the art, I am no experienced ASCII artist by any means. I tried my best and worked with the ASCII Table found on the web. But if you know any glyphs I could have used instead, feel free to enhance them. But I could not find anything that worked for me.

@apjanke
Copy link
Collaborator

apjanke commented Nov 7, 2022

Yeah, that's what I'm talkin' about!

Please see #32 (comment) for discussion on the old PR. This here PR addresses all the comments/questions I had there, so I'm just merging it here, and not gonna copy/paste all that commentary.

Thanks for your cow-ntribution, @Inf166!

@apjanke apjanke merged commit 5914eac into cowsay-org:master Nov 7, 2022
@apjanke
Copy link
Collaborator

apjanke commented Dec 1, 2024

Hi, @mai-space ! I'm trying to clarify and harmonize the licensing situation for Cowsay and this cowsay-org fork.

Would you be willing to expand the license grant on your contribution here to be "GPL 1.0 or later, or Artistic License 1.0", matching the original Cowsay licensing terms?

From 2019 to November 2024, this cowsay-org fork was labeled as being licensed under just GPL 3.0, not the broader original Cowsay terms. I think that means your contribution is implicitly licensed under GPL 3.0. An explicit grant of the broader "GPL 1.0+ or Artistic" licensing would ensure that the licensing for this file is compatible with the old school Cowsay licensing, and we can eventually unify and simplify the licensing for the whole package.

@mai-space
Copy link
Contributor Author

I am all for unifying the community. I just could not contribute to the original repository.

This was really just a funny side project for having alpacas on my CLI.

If you want, you can update the license in a pull request and I will gladly support that initiative!

@apjanke
Copy link
Collaborator

apjanke commented Dec 1, 2024

Excellent!

Here's a PR to update the license grant documentation for your alpaca: #75. If you could drop a comment there approving this update or do an "Approve" PR review, I think that's all that's needed.

Thanks for being up for this.

@apjanke apjanke added the cows New cows! label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cows New cows!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants