Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insight): remove text-xs from badge #4736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mikegron
Copy link
Contributor

@mikegron mikegron commented Nov 28, 2024

SVCC-4314

Removing text-xs that is a fixed text size from stencil (0.75rem) so that the badges can scale with --atomic-text variables:

ex:
image

after:
image

@mikegron mikegron self-assigned this Nov 28, 2024
@mikegron mikegron requested a review from a team as a code owner November 28, 2024 19:39
Copy link

github-actions bot commented Nov 28, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.6 242.6 0
commerce 347.3 347.3 0
search 413.8 413.8 0
insight 404.9 404.9 0
recommendation 254.9 254.9 0
ssr 407.3 407.3 0
ssr-commerce 362.3 362.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@mikegron mikegron changed the title feat(insight) remove text-xs from badge feat(insight): remove text-xs from badge Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants