Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(headless): capi 1587 facets are duplicated in capi request payload when using manual numeric facets #4734

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BenKandelaars
Copy link
Contributor

@BenKandelaars BenKandelaars commented Nov 28, 2024

CAPI-1587

Fix for a couple of issues in headless, as found in Barca with numerical range facets (manual range facets in Headless)

  • Remove duplicate facet's from the CAPI request
  • Remove duplicate facet state from URL fragment
  • Remove deselected numerical facet values from URL fragment

Curious I found a bug in the actions.test.ts file that meant the test should have been failing due to the duplicate facet in CAPI request bug but it passed. Fixing the bug now passes with the fixed code.

Current:
https://github.com/user-attachments/assets/9a075b2e-7dcb-4d65-b813-7f8ea8dc6129

Fix:
https://github.com/user-attachments/assets/0d78b0b2-dab0-400d-9483-23de0391912c

Copy link

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 242.6 242.6 0
commerce 347.3 347.5 0.1
search 413.8 413.7 0
insight 404.9 404.8 0
recommendation 254.9 254.9 0
ssr 407.3 407.2 0
ssr-commerce 362.3 362.6 0.1

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@BenKandelaars BenKandelaars marked this pull request as ready for review November 29, 2024 15:05
@BenKandelaars BenKandelaars requested a review from a team as a code owner November 29, 2024 15:05
@BenKandelaars BenKandelaars force-pushed the CAPI-1587-facets-are-duplicated-in-capi-request-payload-when-using-manual-numeric-facets branch from 9547070 to 23d33a6 Compare November 29, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant