-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quantic): added logic to include quantic version in analytic payloads #4685
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with adding a new static resource is that this requires at minimum a network call to load it.
I would much rather we simply create a version.js
file under quanticUtils
for example, and simply write this in it:
export const version = '3.3.0';
and under quanticUtils.js
we can have export * from './version.js';
and then we can import {version} from 'c/quanticUtils';
wherever we need it, this way instead of a new network call to load a static resource, it'll already be compiled in the components themselves who need it.
The reason I did not go for the QuanticUtils solution is because I didn't want to source control a file that we are not supposed to change and that should not be change manually. Additionally, preserving this information in the Quantic Utils would probably require a logic that will automatically commit a change in this Another reason , less important the the two others, is to avoid writing the same information twice in our codebase, in the In the other hand, using static resources, true that it is an additional network call but I think we can all agree that it's insignificant in a Salesforce Env, especially that the file to be fetch is extremely light so practically I don't think there is a concrete or noticeable impact. That being said, and because static resource is a natural way of handling this in SF, when I balanced the pros and cons I found that using static resources seems better than using the Quantic Utils. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can, try to make this appear as rename, but otherwise all seems good!
SFINT-5760
Description
Created the logic that will include the Quantic version in the analytic payloads pf every event logged by a Quantic component.
This logic relies on a new static resource that I created called.
quanticMetadata
which is a JSON file that contains the Quantic version, that's how it will work:quanticMetadata.json
.