feat(headless): refresh commerce recommendations server-side #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lakhdar
commented
Oct 31, 2024
packages/headless/src/controllers/commerce/recommendations/headless-recommendations.ssr.ts
Outdated
Show resolved
Hide resolved
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
commented
Nov 4, 2024
packages/headless/src/controllers/commerce/recommendations/headless-recommendations.ssr.ts
Outdated
Show resolved
Hide resolved
y-lakhdar
changed the title
y-lakhdar
changed the title
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
There was a problem hiding this comment.
LGTM, nit pik.
It's quite complex tho for me to review this. @fbeaudoincoveo will probably understand it better than me.
packages/headless/src/app/commerce-ssr-engine/factories/recommendation-static-state-factory.ts
Outdated
Show resolved
Hide resolved
packages/headless/src/app/commerce-ssr-engine/types/fetch-static-state.ts
Show resolved
Hide resolved
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
https://coveord.atlassian.net/browse/KIT-3758 While drafting Commerce SSR docs, I noticed that we had no annotations for NavigatorContext, which I thought would be useful.
jpmarceau
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Nov 26, 2024
packages/headless/src/app/commerce-ssr-engine/factories/build-factory.ts
Outdated
Show resolved
Hide resolved
packages/samples/headless-ssr-commerce/app/(listing)/[category]/page.tsx
Show resolved
Hide resolved
packages/samples/headless-ssr-commerce/components/recommendations/popular-viewed.tsx
Outdated
Show resolved
Hide resolved
…factory.ts Co-authored-by: Frederic Beaudoin <fbeaudoin@coveo.com>
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding server-side rendering for commerce SSR package only.
headless-reactpackage to reflect the new changesheadless-ssr-commercesample to reflect the new changesFeatures
Customizable Recommendation Controller
Recommendation Name Validation
Code to increase readability
Factory methods
Moved factory methods into dedicated files to avoid bloating the
commerce-engine-ssrfile.Examples include:
hydrated-state-factory.tsstatic-state-factory.tsCore Engine Types
Centralized all core engine types into
types/core-engine.ts.Recommendation State Factories
Created dedicated factories for handling static and hydrated states for recommendations (
recommendation-static-state-factory.ts).Improved Controller Handling
Simplified the logic for building controllers based on solution type to eliminate complex, hard-to-read conditional blocks (677fd45)
https://coveord.atlassian.net/browse/KIT-3503