Skip to content

Commit

Permalink
fix(quantic): weird height issue in generated answers containing lists (
Browse files Browse the repository at this point in the history
#4728)

[SFINT-5597](https://coveord.atlassian.net/browse/SFINT-5597)

## ISSUE:

- The generated answer generated had a `whitespace: 'pre-wrap'` CSS
style on it which was causing this extra height between elements of the
generated lists.

## PROPOSED SOLUTION:
- Removing the `pre-wrap` I was suspicious about removing it since it
was probably there for a reason. However, I did check with about 20
different queries and double checked with all sorts of screen widths and
it seems to be working as expected.
- I also checked on atomic search pages in the builder, it did not seem
to apply the pre-wrap.

## DEMO:

Before:
<img width="776" alt="image"
src="https://github.com/user-attachments/assets/79106b84-f40a-4edc-9fd6-febd0f29a112">


After:
<img width="932" alt="image"
src="https://github.com/user-attachments/assets/2d02ee78-d44f-4780-ad7e-29b4e403bfb2">




https://github.com/user-attachments/assets/adb7a305-a2cd-4986-b87b-b4fbdcae4f30


Community link:
https://agility-data-1815-dev-ed.scratch.my.site.com/s/

[SFINT-5597]:
https://coveord.atlassian.net/browse/SFINT-5597?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
  • Loading branch information
SimonMilord authored Nov 28, 2024
1 parent 8156e01 commit a3b8f8d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
}

.generated-answer__answer {
white-space: pre-wrap;
overflow: hidden;
position: relative;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ blockquote {
}

.scrollable-table {
margin-top: var(--lwc-spacingLarge, 1.5rem);
margin-bottom: var(--lwc-spacingLarge, 1.5rem);
display: inline-block;
border: 1px solid;
Expand Down

0 comments on commit a3b8f8d

Please sign in to comment.