chore: synchronize type-react dependencies (#4659)

https://coveord.atlassian.net/browse/KIT-3701
coveo · Nov 18, 2024 · 195b9ac · 195b9ac
1 parent fbd4835
commit 195b9ac
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 64 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/samples/headless-ssr-commerce/components/providers/listing-provider.tsx b/packages/samples/headless-ssr-commerce/components/providers/listing-provider.tsx
@@ -50,17 +50,15 @@ export default function ListingProvider({
         engine={hydratedState.engine}
         controllers={hydratedState.controllers}
       >
-        <>{children}</>
+        {children}
       </listingEngineDefinition.HydratedStateProvider>
     );
   } else {
     return (
       <listingEngineDefinition.StaticStateProvider
         controllers={staticState.controllers}
       >
-        {/* // TODO: Add KIT-3701:  Type 'React.ReactNode' is not assignable to type 'import(".../node_modules/@types/react/index").ReactNode'.
-  Type 'bigint' is not assignable to type 'ReactNode'.*/}
-        <>{children}</>
+        {children}
       </listingEngineDefinition.StaticStateProvider>
     );
   }

diff --git a/packages/samples/headless-ssr-commerce/components/providers/search-provider.tsx b/packages/samples/headless-ssr-commerce/components/providers/search-provider.tsx
@@ -51,19 +51,15 @@ export default function SearchProvider({
         engine={hydratedState.engine}
         controllers={hydratedState.controllers}
       >
-        {/* // TODO: KIT-3701: Type 'React.ReactNode' is not assignable to type 'import(".../node_modules/@types/react/index").ReactNode'.
-  Type 'bigint' is not assignable to type 'ReactNode'.*/}
-        <>{children}</>
+        {children}
       </searchEngineDefinition.HydratedStateProvider>
     );
   } else {
     return (
       <searchEngineDefinition.StaticStateProvider
         controllers={staticState.controllers}
       >
-        {/* // TODO: KIT-3701: Type 'React.ReactNode' is not assignable to type 'import(".../node_modules/@types/react/index").ReactNode'.
-  Type 'bigint' is not assignable to type 'ReactNode'.*/}
-        <>{children}</>
+        {children}
       </searchEngineDefinition.StaticStateProvider>
     );
   }

diff --git a/packages/samples/headless-ssr-commerce/package.json b/packages/samples/headless-ssr-commerce/package.json
@@ -18,8 +18,8 @@
   },
   "devDependencies": {
     "@types/node": "20.14.12",
-    "@types/react": "^18.2.0",
-    "@types/react-dom": "^18.2.0",
+    "@types/react": "18.3.3",
+    "@types/react-dom": "18.3.0",
     "eslint": "8.57",
     "eslint-config-next": "14.2.5",
     "typescript": "5.4.5"

diff --git a/packages/samples/headless-ssr/package.json b/packages/samples/headless-ssr/package.json
@@ -16,8 +16,8 @@
   },
   "devDependencies": {
     "@types/node": "20.14.12",
-    "@types/react": "^18.2.0",
-    "@types/react-dom": "^18.2.0",
+    "@types/react": "18.3.3",
+    "@types/react-dom": "18.3.0",
     "eslint": "8.57.0",
     "eslint-config-react-app": "7.0.1",
     "typescript": "5.4.5",