Skip all docs index creation for new deployment #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirav24
force-pushed
the
skip-all-docs-index-creation-for-new-deployment
branch
3 times, most recently
from
fd27cca
to
b773173
Compare
nirav24
force-pushed
the
skip-all-docs-index-creation-for-new-deployment
branch
from
857e72b
to
97c1780
Compare
nirav24
commented
Jan 10, 2023
| @@ -329,7 +329,7 @@ func filterViewResult(input sgbucket.ViewResult, user auth.User, applyChannelFil | |||
| // Is any item of channels found in visibleChannels? | |||
| func channelsIntersect(visibleChannels ch.TimedSet, channels []interface{}) bool { | |||
| for _, channel := range channels { | |||
| if visibleChannels.Contains(channel.(string)) || channel == "*" { | |||
| if visibleChannels.Contains(channel.(string)) { | |||
There was a problem hiding this comment.
@adamcfraser please confirm removing this or condition is okay. I don't understand why the * channel was checked in the first place. This fixes rest/TestUserViewQuery test which was getting 2 documents but was expecting just one.
nirav24
force-pushed
the
skip-all-docs-index-creation-for-new-deployment
branch
2 times, most recently
from
b0592c5
to
cca6101
Compare
nirav24
force-pushed
the
skip-all-docs-index-creation-for-new-deployment
branch
from
9a707f5
to
1aac440
Compare
nirav24
force-pushed
the
skip-all-docs-index-creation-for-new-deployment
branch
from
1fda8d5
to
3af6e46
Compare
nirav24
force-pushed
the
skip-all-docs-index-creation-for-new-deployment
branch
from
3af6e46
to
246112c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-0000
Describe your PR here...
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/1292/