Implemented smtp client certificate validation and introduced 2 new events if smtp server fails to bind to a socket #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md
…icateValidator.cs class to show example
…cate-validation-remote-callback Implemented client certificate validation callback
…the-listener Added a new events for the listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @cosullivan!
I hope this pull request finds you well😅
Thank you for engineering this great lib😄 The flexibility it provides is really awsome, however I ran into a few specific problems that I could not find a reliable workaround for😅 This pull request aims to solve them and extend already impressive feature set of this lib!
I tried to be consistent with your codestyle and implement these features as seamlessly as I could, so everyone who are comfortable with the codebase should feel right at home😃 And of course, all code changes are completely backwards compatible, so no breaking of consumer code!
These features have also been tested with different positive and negative scenarios using stub smtp client, I also tested backwards compatibility so I'm confidend in their stability👍
Additionally I've covered new feature set with tests, added a class with example on how to implement client certificate validation (similarly to existing examples) and I also updated the readme.md to display the new feature😎
I'd really appreciate your review and looking forward to merging these features into main🔥
Have a wonderful day!
P.S. No British words were harmed in the process!😂