Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teensy 4.1: support ADC pins 14-17 #103

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

3hhh
Copy link
Contributor

@3hhh 3hhh commented Oct 12, 2023

Fixes #102

@3hhh
Copy link
Contributor Author

3hhh commented Oct 14, 2023

Possibly using absolute/real pin numbers everywhere for the Teensy in the form of the Ax notation would be even better and get rid of any translation issues.

I can try that as well, if you're interested.

@corrados
Copy link
Owner

If it is just in section "Teensy 4.0/4.1/3.6" and has no influence on my main hardware ESP32 "ESP32 Dual Core" section, then yes. In the end it would just be a translation function from string to int. So, you would define a new vector in get_prototype_pins which contains the strings and then a loop over all values using a Teensy API translation function to generate analog_pins1 integer values. That change would be very small.

@3hhh
Copy link
Contributor Author

3hhh commented Oct 14, 2023 via email

@corrados
Copy link
Owner

Thanks, but before I merge anything, I'll wait until you have your new Teensy and are happy with the results :-).

@3hhh
Copy link
Contributor Author

3hhh commented Oct 20, 2023

I tested this with the working Teensy by now. It works just fine.

@corrados corrados changed the base branch from main to integration_3hhh_103 October 24, 2023 16:14
@corrados corrados merged commit 5460e07 into corrados:integration_3hhh_103 Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teensy: High pins don't work
2 participants