-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate Wrapped Data - updated version #895
base: master
Are you sure you want to change the base?
Conversation
- added some extra checks and made some anon functions have more clear names
[diff-counting] Significant lines: 858. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems logically correct to me! Great work with this over the past couple of months and handling complex cases with fav TA and stuff. I'm still a bit nervous about the scale of reads/writes we're running, so one option would be to subdivide the date ranges even more, but we can figure that out on Monday.
.github/workflows/cd.yml
Outdated
@@ -2,7 +2,7 @@ name: CD | |||
on: | |||
push: | |||
branches: | |||
- master | |||
- main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh also prob don't include this change and the one in the readme
Hi Nidhi! Thanks for adding the fields for favorite day, favorite month, and number of students helped! The logic for favMonth makes sense and I like that you returned them as numbers since it was very intuitive to incorporate! Your comments throughout are also very helpful when looking over your code! I did notice a few commented out console statements that maybe can be removed? |
Summary
Made lots of edits to base code.
Test Plan
Breaking Changes
None