-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QMI Wrapped Intro Animation #869
base: master
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 338. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work here with the intro animation Nidhi! It's exciting to see Sia's Figma designs slowly come to life, and I'm looking forward to getting this to prod. Great job figuring this out by yourself and for leaving helpful comments explaining how it works haha
Visually the only thing I'd make note of is the speed of the animation – we can sync up on that during the next couple weeks with the designers.
Since the Wrapped Frontend setup PR has been merged, we should be good to add this animation in to the beginning of the slideshow modal. And in that PR, we created a media/wrapped folder so remember to add the svgs here to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The animation modal looks very good viusally and reflects the figma very well. It's just a small minor nitpick of a particularly <def>
tag in the WrappedAnimationModal
component in which I already commented in that code block. But this was amazing implementation to make the modal so dynamic :)
Summary
Created a temporary button on top navbar to show a modal with the QMI Wrapped intro animation.
Screen.Recording.2024-09-22.at.5.05.14.PM.mov
Test Plan
Notes
Breaking Changes
None
Checklist