-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix report abuse #380
base: main
Are you sure you want to change the base?
Fix report abuse #380
Conversation
- Add report validation - Update review status endpoint - Prevent reporting of pending reviews and own reviews
- Add report confirmation modal - Add report button logic - Prevent reporting of own reviews
- Show reported reviews in apartment page - Add reported reviews section to profile page - Add success toast notifications
[diff-counting] Significant lines: 351. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Review
You implemented the report abuse confirmation modal really well with no flaws, and the toast works correctly as expected. Good work on these parts.
You also adjusted the app.ts really well, I love the security checks and the logic works correctly.
I like the addition of the collapsing arrows and it really helps improve the user experience! One minor change would be to switch the open and close state direction to match the convention across our site, so just flip the rotate CSS.
This is the current state, but it should be the opposite.
Summary
This pull request enhanced the Report Abuse feature for reviews. The new Report Abuse feature provides a more comprehensive process for reporting reviews, and allowing admin to monitor reported reviews to take actions.
Main Requirements Completed:
Backend Changes Completed:
date
,reason
, anduserId
reason
field will require future frontend processREPORTED
review statusFrontend Changes Completed:
APPROVED
andREPORTED
reviews)Review Status Flow Fixed:
Edge Cases Handled:
Test Plan
*Reported reviews in profile page: 1. Reported reviews can't be edited/deleted. 2. Can't report self's reviews.
*Only able to report other users' review. REPORTED reviews are still visible.
*Admin page reported review display
*Admin page review section dropdown menu
Test the following flows:
Regular user flow:
Edge cases:
Notes
Breaking Changes
reports
array field to review documents (lazy migration)Future Plans