-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted save image button #378
base: main
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 52. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a simple and great fix to the historical issue; the implementation is clean and works well!
Screen.Recording.2024-11-17.at.23.31.38.mov
One small frontend enhancement: Currently the hover state of the saved button moves many components of the page as shown. It might be better to remove this effect unless this is an intentional design.
PR Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is great and the button's design works as intended. After resolving minor issues with material-ui styling, the button now works perfectly.
Summary
This pull request fixes the bug where our save apartment button is an image and not an actual button as requested by PM.
Test Plan
Apartment when saved:Notes