-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Ride Modal Styling #506
base: master
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 90. |
Hi Selena, great work on redesigning the Modal and adding the Clear All button, everthing looks clean and follows Lazim's design closely. I am not exactly sure why the DaySelector might not show up since you didn't change the name of the select component for the repeats. But, you can try to change the size of the modal by adding height and width properties to the .form in ridemodal.module.css. When you add these properties, try to use rem instead of px since that's better for responsive design. Here is a converter between px and rem: https://nekocalc.com/px-to-rem-converter. Also, I think you need to run prettier on ridermodal.module.css to make the failed check go away. |
…663/ride_modal_styling
…663/ride_modal_styling
…663/ride_modal_styling
…663/ride_modal_styling
Summary
This pull request is a work in progress for implementing the new designs for adding a ride. I added the Clear All button, added icons, and fixed formatting, ie. having labels and inputs on separate lines.
Test Plan
updated after merging:
previous:
I continuously tested between each change I made.
Notes
Still need to figure out how to make the modal larger, and fix Repeats.
Created a container that is used in Ride Information Modal as well, will need to fix.
Breaking Changes
When I click on Custom under the Repeats dropdown, the additional info doesn't currently pop up.