Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the wsc/game-story API endpoint #89

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

willdeberry
Copy link
Contributor

@willdeberry willdeberry commented Nov 25, 2024

The calls and details I found via https://github.com/Zmalski/NHL-API-Reference?tab=readme-ov-file#get-game-story

Essentially this API is the new API found game end stats such as overall PP, PK, FaceOff Win percentage, blocked shots, etc. This was originally part of the summary section of the boxscore but looks like for this season, gamecenter/summary is now an empty dict and all that info has been moved to this new API.

@coreyjs
Copy link
Owner

coreyjs commented Nov 25, 2024

Can you give a little more insight into this PR and background to these api calls? Where can I find the wsc endpoints in use on the NHL site? I am not familiar with them. If you can update the PR description with them that would be great. I appreciate the contribution.

@willdeberry
Copy link
Contributor Author

Also looks like there is a new rightRail API which provides similar information and is expanded on gamecenter. I can try and tackle that tonight as well https://api-web.nhle.com/v1/gamecenter/2024020318/right-rail and can be seen on page https://www.nhl.com/gamecenter/chi-vs-phi/2024/11/23/2024020318/summary

@coreyjs coreyjs self-requested a review November 25, 2024 18:39
@coreyjs
Copy link
Owner

coreyjs commented Nov 25, 2024

Gotcha sounds good. Any idea what "wsc" stands for? I was digging around but couldn't find anything.

Also to pass the build just make sure to run locally both black and ruff and get those passing. Shouldn't be much.

$   black .
$   ruff .

These are just linters and formatters.

@willdeberry
Copy link
Contributor Author

Linting/formatting errors resolved

@willdeberry
Copy link
Contributor Author

Gotcha sounds good. Any idea what "wsc" stands for? I was digging around but couldn't find anything.

Also to pass the build just make sure to run locally both black and ruff and get those passing. Shouldn't be much.

$   black .
$   ruff .

These are just linters and formatters.

Not sure what it stands for. Outside of the other project that is keeping track of the APIs avail, I haven't been able to locate it manually on the NHL.com website. Not sure what it stands for but W (something) Stanley Cup is all I can come up with lol

@coreyjs
Copy link
Owner

coreyjs commented Nov 25, 2024

I wonder if it makes sense just to move this under gamecenter. That acronym is throwing me off lol. There seems to be only one wsc endpoint at this time anyways.

@willdeberry
Copy link
Contributor Author

I wonder if it makes sense just to move this under gamecenter. That acronym is throwing me off lol. There seems to be only one wsc endpoint at this time anyways.

I can definitely move it there, until we come across item number 2 to create a new grouping

@willdeberry
Copy link
Contributor Author

@coreyjs went ahead and moved it to gamecenter and if/when we come across more of these, we can readjust at that point.

@coreyjs coreyjs merged commit 710986b into coreyjs:main Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants