Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Private Bin and Redlib Service #4209

Merged
merged 14 commits into from
Nov 25, 2024

Conversation

librelol
Copy link
Contributor

@librelol librelol commented Nov 9, 2024

New Services

  • Private Bin
  • Redlib

@librelol
Copy link
Contributor Author

librelol commented Nov 9, 2024

I believed I followed all the contribution rules. Let me know if I missed anything. Thank you.

@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Nov 9, 2024
@peaklabs-dev peaklabs-dev self-assigned this Nov 9, 2024
@peaklabs-dev peaklabs-dev changed the base branch from next to services November 9, 2024 15:03
templates/compose/redlib.yaml Outdated Show resolved Hide resolved
@peaklabs-dev
Copy link
Member

  1. Please add logos to your services.
  2. Also add healtchecks to both services.
  3. Also test them by inserting the compose into the compose deplyo type, because the first one I tried did not really work.

@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 12, 2024
@RayBB
Copy link
Contributor

RayBB commented Nov 13, 2024

Sweet I love redlib!

@librelol
Copy link
Contributor Author

  1. Please add logos to your services.

    1. Also add healtchecks to both services.

    2. Also test them by inserting the compose into the compose deplyo type, because the first one I tried did not really work.

Sure thing man, I had them running on my service actually but I'll follow through with those.

@librelol
Copy link
Contributor Author

  1. Please add logos to your services.

    1. Also add healtchecks to both services.

    2. Also test them by inserting the compose into the compose deplyo type, because the first one I tried did not really work.

Also redlib on start takes a good couple of minutes to actually start working.

@librelol
Copy link
Contributor Author

I've observed that Redlib is pretty unreliable. It will need some more testing.

@RayBB
Copy link
Contributor

RayBB commented Nov 14, 2024

It's weird because redlib not running behine coolify works flawlessly. But when it's behind coolify it often times out. If I ssh into the container and curl the service it always responds basically instantly. It makes me think there's something weird about the reverse proxy config. There's a small chance it could be related to the face that redlib doesn't support head requests but idk.

@peaklabs-dev peaklabs-dev removed the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 14, 2024
@peaklabs-dev
Copy link
Member

I will mark it as draft, when you are done pleas make it ready for review.

@peaklabs-dev peaklabs-dev marked this pull request as draft November 14, 2024 20:24
@peaklabs-dev peaklabs-dev changed the title Feat: New Services Feat: Private Bin and Redlib Service Nov 14, 2024
@peaklabs-dev peaklabs-dev added the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 15, 2024
…on the built in option "default" wouldn't work. But you are able to chang it to anything you want.
@librelol
Copy link
Contributor Author

It's weird because redlib not running behine coolify works flawlessly. But when it's behind coolify it often times out. If I ssh into the container and curl the service it always responds basically instantly. It makes me think there's something weird about the reverse proxy config. There's a small chance it could be related to the face that redlib doesn't support head requests but idk.

I don't think so. It just takes a bit to startup. I think it might have to do with something relating to indexing reddit? But apart from that I got it to work without a problem mostly. I will do some more testing in general with the variables to ensure a stable production experience since its pretty unreliable right now.

@librelol
Copy link
Contributor Author

I ended up changing the default sub reddit to worldnews due to for whatever reason the example option redlib gives for it doesn't actually work.

@librelol
Copy link
Contributor Author

Alright, Redlib seems to be pretty stable. And I've implemented the proper coolify environment variables. I think it is ready, I also have been running redlib for about 3 hours and it has no problems accessing various sub reddits and the homepage is working well now that it is set to world news.

@librelol librelol marked this pull request as ready for review November 15, 2024 22:18
@peaklabs-dev peaklabs-dev removed the 💤 Waiting for feedback Issues awaiting a response from the author. label Nov 19, 2024
@peaklabs-dev peaklabs-dev deleted the branch coollabsio:services November 22, 2024 20:38
@peaklabs-dev peaklabs-dev reopened this Nov 22, 2024
@peaklabs-dev
Copy link
Member

Thanks for the PR, next time please make separate PRs for each service. Also, I will not add Gothub because it is too small a service to officially maintain.

@peaklabs-dev peaklabs-dev merged commit 3a35e9c into coollabsio:services Nov 25, 2024
1 check passed
@github-actions github-actions bot removed the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants