Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of WithTransaction #209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make use of WithTransaction #209

wants to merge 1 commit into from

Conversation

HileQAQ
Copy link
Contributor

@HileQAQ HileQAQ commented Jun 26, 2023

What this PR does / why we need it:
Refer to this, we need to synchronize with containerd's overlay snapshotter. Use WithTransaction rather than TransactionContext.

This PR also has other changes:

  • change the Golang version required in the documentation to 1.19+
  • refer to this commit, I have modified the github.com/containerd/containerd/pkg/seed import to pass the Linter check.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Haoqi Miao <miaohaoqi.mhq@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant