Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set python_min to 3.8 and remove runtime dep on opencv #60

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Nov 24, 2024

Patches #59 with the following changes:

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@weiji14 weiji14 self-assigned this Nov 24, 2024
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Constrained by shapely>1.8.0 which uses Python 3.7+
@weiji14 weiji14 changed the title Set python min and remove runtime dep on opencv Set python_min to 3.7 and remove runtime dep on opencv Nov 24, 2024
@weiji14
Copy link
Member Author

weiji14 commented Nov 24, 2024

Getting this error on import sahi:

import: 'sahi'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/sahi_1732418500825/test_tmp/run_test.py", line 2, in <module>
    import sahi
  File "/home/conda/feedstock_root/build_artifacts/sahi_1732418500825/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.7/site-packages/sahi/__init__.py", line 3, in <module>
    from sahi.annotation import BoundingBox, Category, Mask
  File "/home/conda/feedstock_root/build_artifacts/sahi_1732418500825/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.7/site-packages/sahi/annotation.py", line 9, in <module>
    from sahi.utils.coco import CocoAnnotation, CocoPrediction
  File "/home/conda/feedstock_root/build_artifacts/sahi_1732418500825/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.7/site-packages/sahi/utils/coco.py", line 17, in <module>
    from shapely import GeometryCollection, MultiPolygon, Polygon
ImportError: cannot import name 'GeometryCollection' from 'shapely' (/home/conda/feedstock_root/build_artifacts/sahi_1732418500825/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.7/site-packages/shapely/__init__.py)

Looks like this was mentioned at obss/sahi#1061 (comment) that shapely>=2.0 is required.

Constrained by shapely>2.0.0 which uses Python 3.8+
@weiji14 weiji14 changed the title Set python_min to 3.7 and remove runtime dep on opencv Set python_min to 3.8 and remove runtime dep on opencv Nov 25, 2024
@weiji14
Copy link
Member Author

weiji14 commented Nov 25, 2024

Note: Also pinning python>3.8 because shapely=2.0.0 on conda-forge only has Python 3.8+ builds (on PyPI, shapely=2.0.0 has Python 3.7 wheels).

@weiji14 weiji14 marked this pull request as ready for review November 25, 2024 01:57
@fcakyon fcakyon merged commit 0c91939 into conda-forge:main Nov 25, 2024
4 checks passed
@weiji14 weiji14 deleted the patch_python_min branch November 25, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants