improve adornment v2 importer typing #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turned up three bugs: - `yAttributeDescriptions.y` doesn't exist - if the v2 document had a plottedStDev adornment a stDev and stErr adornment would be added to the imported document - the creation of this erroneous stErr adornment did not set to the number of standard errors correctly. The importer now handles an older format of the multipleMovableValues adornment
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1658 +/- ##
==========================================
+ Coverage 85.69% 85.77% +0.07%
==========================================
Files 604 604
Lines 30740 30742 +2
Branches 7895 7896 +1
==========================================
+ Hits 26344 26368 +24
+ Misses 4241 4219 -22
Partials 155 155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 02m 09s |
| Commit |
|
| Committer | eireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
3
|
| View all changes introduced in this branch ↗︎ | |
kswenson
approved these changes
Nov 28, 2024
Comment on lines
120
to
121
| // TODO_V2_IMPORT: This used to be yAttributeDescriptions.y, which would have always been undefined | ||
| // I'm not sure if yAttributeDescriptions[0] is the right replacement. |
There was a problem hiding this comment.
I think yAttributeDescriptions[0] is correct.
| @@ -128,21 +153,31 @@ const instanceKeysForAdornments = (props: IInstanceKeysForAdornmentsProps) => { | |||
| return instanceKeys | |||
| } | |||
|
|
|||
| export type AdornmentAttributeDescriptions = Partial<Record<GraphAttrRole, IAttributeDescriptionSnapshot>> | |||
There was a problem hiding this comment.
AdornmentAttributeDescriptions aren't adornment specific, so I'd be inclined to call it something like GraphAttributeDescriptions and move the definition into data-display-types.ts or graphing-types.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned up three bugs:
yAttributeDescriptions.ydoesn't existThe importer now handles an older format of the multipleMovableValues adornment.
This also fixes other v2 types that didn't match the one random document from cfm-shared. I'll be checking more documents and will an submit a new PR with those changes.