188618452 new table clean up #1653
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes case table default width to the width of one attribute
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1653 +/- ##
==========================================
- Coverage 85.71% 81.27% -4.45%
==========================================
Files 603 603
Lines 30591 30627 +36
Branches 8410 8366 -44
==========================================
- Hits 26221 24892 -1329
- Misses 4049 5354 +1305
- Partials 321 381 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codap-v3
|
||||||||||||||||||||||||||||||||||||||||
| Project |
codap-v3
|
| Branch Review |
188618452-new-table-clean-up
|
| Run status |
|
| Run duration | 06m 23s |
| Commit |
|
| Committer | eireland |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
36
|
Skipped
|
0
|
Passing
|
218
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
plugin.spec.ts • 1 failed test • Regression Tests
| Test | Artifacts | |
|---|---|---|
| codap plugins > will broadcast notifications |
Test Replay
Screenshots
|
|
formula/formula-component.spec.ts • 1 failed test • Regression Tests
| Test | Artifacts | |
|---|---|---|
| Formula Engine > Component Formula Tests > Formula in a new dataset |
Test Replay
Screenshots
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On new tables:
--new--in the table menu default width to just show the one default column