Add pybind11 to the whitelist for KB-h016 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
4 tasks
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
@danimtb I just update it. Rather than putting pybind11 in whitelist, now any custom find cmake file is allowed. Take a look. |
|
Seems like the last change related to Python 2.7 affected us. Should we drop the tests involving Python 2.7 ? |
|
We are not dropping Python 2 support in the CI yet, please see #146 |
|
Restarting in 3 .. 2 .. 1 .. |
|
@uilianries please update this PR with the latest changes in master branch to kick the CI |
|
Just a note: I am a bit hesitant about the changes in this PR as packages may have other Find*.cmake files to find other libraries. I think we have to make sure that the file is declared in cpp_info.build_modules mandatory, so we are able to see it in the PR diff inside the recipe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: conan-io/conan-center-index#464
/cc @danimtb @madebr