Use cpp_info.frameworks instead of cpp_info.exe_link_flags #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
uilianries
changed the title
|
All conflicts has been solved. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
…o hook/osx-frameworks
Signed-off-by: Uilian Ries <uilianries@gmail.com>
SSE4
reviewed
Nov 13, 2019
| @@ -276,6 +277,11 @@ def test(out): | |||
| out.error("The 'RunEnvironment()' build helper is no longer needed. " | |||
| "It has been integrated into the self.run(..., run_environment=True)") | |||
|
|
|||
| @run_test("KB-H033", output) | |||
| def test(out): | |||
| if "cpp_info.shared_link_flags" in conanfile_content and "-framework" in conanfile_content: | |||
There was a problem hiding this comment.
that might trigger false positives, need to reduce scope of test
There was a problem hiding this comment.
can you elaborate some idea?
There was a problem hiding this comment.
having something like:
self.cpp_info.shared_link_flags = ["-B,Symbolic"]
...
tools.replace_in_file("Makefile", "-framework Foundation", "-framework CoreFoundation")
will result in false positive I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Apple Framework support, now all recipes using
exe_link_flagsfor OSX framework should usecpp_info.frameworksinstead.closes #108
Wiki:
#KB-H033: "APPLE FRAMEWORK"
When liking Apple frameworks into your current recipe, instead of
self.cpp_info.shared_link_flags, useself.cpp_info.frameworks: