Some improvements for test duration on Windows #17221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbrilRBS
commented
Oct 25, 2024
| @@ -13,7 +13,7 @@ def test_graph_build_order_override_error(): | |||
| |--------------/ | |||
| |-----override------> zlib/1.3 | |||
| """ | |||
| c = TestClient() | |||
| c = TestClient(light=True) | |||
There was a problem hiding this comment.
Settings copy was a prevalent time sink as per cProfile output of this file, and in my Parallels machine this goes from 63s to 24
AbrilRBS
commented
Oct 25, 2024
| @@ -456,7 +456,7 @@ def __init__(self, cache_folder=None, current_folder=None, servers=None, inputs= | |||
| # create default profile | |||
| if light: | |||
| text = "[settings]\nos=Linux" # Needed at least build-os | |||
| save(self.cache.settings_path, "os: [Linux]") | |||
| save(self.cache.settings_path, "os: [Linux, Windows]") | |||
There was a problem hiding this comment.
If the aim is to speed up Windows, makes sense to need it here too
memsharded
approved these changes
Oct 25, 2024
czoido
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Omit
Docs: Omit
new_testremoval removes 1 min in Windows, theTurboTestClient()->TestClient()changes are 20% faster on my machine, and theci_overrideschanges has a 3x speedup locallycf #17205