Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added a hacky way to add slow5/blow5 reading to radian.
I didn't want to change the interface or args, as I think that should be left to the authors, but I have shown how easy it is to implement and added some comments for clarity.
I timed myself doing this as well.
~8min for:
then ~52min for:
So about 1h.
Thanks!
P.S:
I've added my notes of this below. I would recommend stating that python3.8 is recommended for installing tensorflow 2.4.4 and to use virtual environments.
Also the tar command puts the output in the wrong folder (I think), I had to move it back to the models folder.
James' Notes:
setting up slow5 hack using fast5dir for *.blow5 file
time taken: 8min
trying to install on laptop
CUDA Version: 11.7 might work? server is 11.1, so will have to see
no python version given. Trying my default of 3.10
no instruction of creating venv, but doing that first
error:
looks like the release compatibility on pypi is for python3.8
so using deadsnakes, installing python3.8
sudo apt install python3.8 python3.8-dev python3.8-venv
okay that worked! (7min so far)
tar -xvzf radian/models/rnamodel_12mer_pc.tar.gz
testing on test data
error:
maybe something to do with numpy
removing and adding again
that doesn't work. Problem is i need to purge the cached pyslow5 build to force it to build again
now that works
trying again
error:
FileNotFoundError: [Errno 2] No such file or directory: 'models/rnamodel_12mer_pc.json'
mv rnamodel_12mer_pc.json radian/models/
can't use my GPU? or something.
anyway, works for CPU on a few reads. That's enough to test.
SO now testing slow5....let's convert the fast5 files (we are at 30min now)
lol! okay that's weird...
opens up file in HDFView
oh...there are 2 signal entries. Let's delete the old_signal entry...
try again with slow5tools....and that works now with slow5tools.
Now let's try slow5 as the input.
yep, that works!
Winning!
Time: 52min.
Total time to implement and test: ~1h