Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of Positive and Negative is inconsistent with Fig 3 for 'Right' Alternative Terminal Exon Events #146

Open
lzx325 opened this issue May 29, 2022 · 0 comments

Comments

@lzx325
Copy link

lzx325 commented May 29, 2022

According to the code of this member function of class ALTR in lib/event.py,

SUPPA/lib/event.py

Lines 309 to 319 in 1c0ad91

def create_altr(self, coord1, coord2, coord3, transcript):
"""
Find and create alternative events
"""
gene = self.gene
for neg1, neg2, neg3 in self.negative_coords:
if neg1 == coord1 and neg2 > coord3:
eventid = '{}:{}-{}:{}:{}-{}:{}:{}'.format(gene.chr, coord1, coord2, coord3,
neg1, neg2, neg3, gene.strand)
self.positive_ids[eventid] = self.positive_ids.get(eventid, []) + [transcript]
self.negative_ids[eventid] = self.negative_coords[(neg1, neg2, neg3)]

Since neg2 > coord3 is guaranteed at L315, the right terminal exon of transcript lies to the left of the exon (neg2,neg3). Therefore, the variable transcript does not denote the isoform containing the 'black exon' in Figure 3. I think the rhs of L318 and L319 should be switched. Am I right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant