Fix parsing of ambiguous classes to avoid ignoring real classes when test ones get scanned first #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test ones get scanned first Refs composer/composer#12140
stof
reviewed
Oct 4, 2024
| * If you want to get these back as well you can pass false to $duplicatesFilter. Or | ||
| * you can pass your own pattern to exclude if you need to change the default. | ||
| * | ||
| * @param non-empty-string|false $duplicatesFilter |
There was a problem hiding this comment.
Why not using null for the absence of filter ? That would be a cleaner API
There was a problem hiding this comment.
Because I started as filter true/false, then figured I could let people customize the filter, and the false stuck. A bit late now that it's been tagged, but it's not really a broadly used API so not such a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @janedbal
Refs composer/composer#12140