Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #5814 - Rotated pictures shown as failed to upload, actually uploaded successfully #5899

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix issue #5814 - Rotated pictures shown as failed to upload, actually uploaded successfully #5899

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c80d20
The issue with database access has been fixed: due to incorrect datab…
QUIETTTTTTTTTT Oct 26, 2024
21e9a30
**Fix 2:** I believe the issue described is actually caused by a fail…
QUIETTTTTTTTTT Oct 26, 2024
038dd46
Merge branch 'main' into main
QUIETTTTTTTTTT Oct 26, 2024
504eb8a
Fix some comments to make them clearer
QUIETTTTTTTTTT Oct 28, 2024
4e07ead
Merge branch 'main' into Comment-fix
QUIETTTTTTTTTT Oct 28, 2024
59f140b
Merge branch 'main' into Comment-fix
QUIETTTTTTTTTT Nov 8, 2024
8d50540
Add final variable WRITE_EXTERNAL_STORAGE_PERMISSION_REQUEST_CODE for…
QUIETTTTTTTTTT Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/src/main/java/fr/free/nrw/commons/edit/EditActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package fr.free.nrw.commons.edit

import android.Manifest
import android.animation.Animator
import android.animation.Animator.AnimatorListener
import android.animation.ValueAnimator
Expand All @@ -20,6 +21,11 @@ import androidx.lifecycle.ViewModelProvider
import fr.free.nrw.commons.databinding.ActivityEditBinding
import timber.log.Timber
import java.io.File
import androidx.core.content.ContextCompat
import android.content.pm.PackageManager
import androidx.core.app.ActivityCompat



/**
* An activity class for editing and rotating images using LLJTran with EXIF attribute preservation.
Expand All @@ -35,6 +41,8 @@ class EditActivity : AppCompatActivity() {
private val sourceExifAttributeList = mutableListOf<Pair<String, String?>>()
private lateinit var binding: ActivityEditBinding

private final var WRITE_EXTERNAL_STORAGE_PERMISSION_REQUEST_CODE = 7747;

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
binding = ActivityEditBinding.inflate(layoutInflater)
Expand Down Expand Up @@ -239,6 +247,12 @@ class EditActivity : AppCompatActivity() {
* as a result, and finishes the current activity.
*/
fun getRotatedImage() {
//Get Permission to access
if (ContextCompat.checkSelfPermission(this, Manifest.permission.WRITE_EXTERNAL_STORAGE)
!= PackageManager.PERMISSION_GRANTED) {
ActivityCompat.requestPermissions(this, arrayOf(Manifest.permission.WRITE_EXTERNAL_STORAGE), WRITE_EXTERNAL_STORAGE_PERMISSION_REQUEST_CODE)
}

val filePath = imageUri.toUri().path
val file = filePath?.let { File(it) }

Expand Down
Loading