Refactor test code to use assertj and using gherkin to define scenarios #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#306 Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
changed the base branch from
feat/304-refactor-and-fix-sclreport-behavior
to
develop
samirromdhani
changed the base branch from
develop
to
feat/304-refactor-and-fix-sclreport-behavior
samirromdhani
changed the title
samirromdhani
deleted the
refactor/306-refactor-test-code-to-use-assertj-and-using-gherkin-to-define-scenarios
branch
samirromdhani
restored the
refactor/306-refactor-test-code-to-use-assertj-and-using-gherkin-to-define-scenarios
branch
samirromdhani
deleted the
refactor/306-refactor-test-code-to-use-assertj-and-using-gherkin-to-define-scenarios
branch
samirromdhani
restored the
refactor/306-refactor-test-code-to-use-assertj-and-using-gherkin-to-define-scenarios
branch
samirromdhani
deleted the
refactor/306-refactor-test-code-to-use-assertj-and-using-gherkin-to-define-scenarios
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an experimental refactor on test scenarios in order to make code more readable and use Gherkin-like syntax. I'd like to collect feedback on it.
I figured out that many services are applied in various scenarios, certain are used to validate tests (Then) and others are used to prepare data required for the method to test so we not have only one When step.