Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing test for property delete in schema #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amir-arad
Copy link
Contributor

@amir-arad amir-arad commented May 8, 2020

This PR adds a failing test for when deleting a property from a schema object does not trigger change events.

@endel
Copy link
Member

endel commented May 8, 2020

That's an interesting find @amir-arad, thanks for the test-case.

As a workaround, you can assign null or undefined to the value you want to delete. It would be nice to support delete state.field directly, though.

I think we'd need another proxy layer behind every Schema instance to allow this.

@amir-arad
Copy link
Contributor Author

@endel sure thing. I'm just documenting what I find. been helping @a-rts write a mobx client, and found this edge, so it's yours to decide what to do with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants