Adding guard against temp directory create failure

createDirectoryAtURL technically is not supposed to take a nil value - guard against this.
colincornaby · Feb 18, 2024 · 87434f2 · 87434f2
1 parent 21df00e
commit 87434f2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSPatcher.mm b/Sources/Plasma/Apps/plClient/Mac-Cocoa/PLSPatcher.mm
@@ -252,8 +252,10 @@ static la_ssize_t copy_data(struct archive *ar, struct archive *aw)
 
     NSError *error;
     NSURL *tempDirectory = [NSFileManager.defaultManager URLForDirectory:NSItemReplacementDirectory inDomain:NSUserDomainMask appropriateForURL:[NSURL fileURLWithPath:NSFileManager.defaultManager.currentDirectoryPath] create:YES error:&error];
-    NSURL *outputURL = [tempDirectory URLByAppendingPathComponent:[NSString stringWithSTString:plManifest::PatcherExecutable().GetFileName()]];
-    [NSFileManager.defaultManager createDirectoryAtURL:outputURL withIntermediateDirectories:false attributes:nil error:&error];
+    if (tempDirectory) {
+        NSURL *outputURL = [tempDirectory URLByAppendingPathComponent:[NSString stringWithSTString:plManifest::PatcherExecutable().GetFileName()]];
+        [NSFileManager.defaultManager createDirectoryAtURL:outputURL withIntermediateDirectories:false attributes:nil error:&error];
+    }
 
     if (error) {
         // Not sure why things would go wrong, we should be able to