Bootstrap file memory issues #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15952
💛 - Coveralls |
xiaying-peng
reviewed
Jan 4, 2022
|
Hi @shrimalmadhur, thanks for opening this PR. I was wondering if there is any update? Thanks alot! |
shrimalmadhur
force-pushed
the
madhur/fix-large-bootstrap
branch
from
9ac3f16
to
2293610
Compare
xiaying-peng
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes .
coinbase/mesh-cli#259
coinbase/mesh-cli#260
Motivation
For motivation please refer #365
Solution
We commit transaction for bootstrap balances in chunks of 600 accounts.
Open questions
I tested it locally with
MaxEntrySizePerTxnto be lower/same than number of account and it worked. I still have not found a clean way to unit test that since that value comes from a const.