Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Changing plan confirmation window #448

Merged
merged 4 commits into from
Jul 24, 2021

Conversation

ilyamore88
Copy link
Member

Closes #444

@ilyamore88 ilyamore88 changed the base branch from master to feature/remove-project-confirmation June 11, 2021 19:57
@neSpecc
Copy link
Member

neSpecc commented Jun 21, 2021

Why we need to confirm changing from Free to Paid plan? I think, in this case, user will see a Payment Dialog and he'll allow dismiss it.

image

@neSpecc
Copy link
Member

neSpecc commented Jun 21, 2021

I'm on paid plan, and I'm clicking on Change to Free. I see wrong text (about payment)

image

@neSpecc
Copy link
Member

neSpecc commented Jun 21, 2021

Clicking on Confirm, but nothing happened. Just closes a confirmation.

Base automatically changed from feature/remove-project-confirmation to master June 24, 2021 10:19
@ilyamore88
Copy link
Member Author

Clicking on Confirm, but nothing happened. Just closes a confirmation.

Can't reproduce.

@neSpecc
Copy link
Member

neSpecc commented Jun 24, 2021

Clicking on Confirm, but nothing happened. Just closes a confirmation.

Can't reproduce.

  1. Select project with paid plan
  2. Change to free
  3. Try to change to paid again — nothing happened

…to feature/change-plan-confirmation-window
@ilyamore88
Copy link
Member Author

@neSpecc, I can't reproduce your bug. Can you test my request again and send more info about the bug: error message, stack trace, etc.

@ilyamore88
Copy link
Member Author

@neSpecc's bug is reproduced without this request. I described this problem in issues #458 and #459.
For changing a workspace plan, you should refresh the page after changing. A new current plan will be displayed on the Billing information page.
There will be no need to refresh the page after payment if the current plan is automatically renewed.

@ilyamore88 ilyamore88 merged commit 18769d5 into master Jul 24, 2021
@ilyamore88 ilyamore88 deleted the feature/change-plan-confirmation-window branch July 24, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Confirmation window to the payment dialog
3 participants