-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add default_apps
field to coder_agent
resource
#147
Conversation
- Enables a template admin to configure which apps are displayed to the user in the dashboard.
os = "linux" | ||
arch = "amd64" | ||
display_apps { | ||
vscode = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need an extra test case to check .tf with only a few apps selected:
display_apps {
vscode = true
web_terminal = true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since they all have default values I tested that specifying their non-defaults (in OK
) and then omitting them to produce the defaults (in Omitted
) produces the desired result. I added another one anyway but I don't think it adds much value.
default_apps
field to coder_agent
resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
just take a look at the comment in examples_test.go
fixes the provider side of coder/coder#8033
It takes the form
display_apps
block you opt-in to the defaults.false
.