Skip to content

Commit

Permalink
chore: calrify the format of url for coder_app resource (#145)
Browse files Browse the repository at this point in the history
* chore: calrify the format of `url` for `coder_app` resource

A user has suggested to clarify the format of `url` in `coder_app` resource.

See : coder/coder#8574 (comment) for related discussion.

* Update app.go

* make gen

* Update app.go

* make gen
  • Loading branch information
matifali authored Jul 19, 2023
1 parent 9ff00d6 commit 188ffef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docs/resources/app.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ resource "coder_app" "intellij" {
- `relative_path` (Boolean, Deprecated) Specifies whether the URL will be accessed via a relative path or wildcard. Use if wildcard routing is unavailable. Defaults to true.
- `share` (String) Determines the "level" which the application is shared at. Valid levels are "owner" (default), "authenticated" and "public". Level "owner" disables sharing on the app, so only the workspace owner can access it. Level "authenticated" shares the app with all authenticated users. Level "public" shares it with any user, including unauthenticated users. Permitted application sharing levels can be configured site-wide via a flag on `coder server` (Enterprise only).
- `subdomain` (Boolean) Determines whether the app will be accessed via it's own subdomain or whether it will be accessed via a path on Coder. If wildcards have not been setup by the administrator then apps with "subdomain" set to true will not be accessible. Defaults to false.
- `url` (String) A URL to be proxied to from inside the workspace. Either "command" or "url" may be specified, but not both.
- `url` (String) A URL to be proxied to from inside the workspace. This should be of the form "http://localhost:PORT[/SUBPATH]". Either "command" or "url" may be specified, but not both.

### Read-Only

Expand Down
1 change: 1 addition & 0 deletions provider/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ func appResource() *schema.Resource {
"url": {
Type: schema.TypeString,
Description: "A URL to be proxied to from inside the workspace. " +
"This should be of the form \"http://localhost:PORT[/SUBPATH]\". " +
"Either \"command\" or \"url\" may be specified, but not both.",
ForceNew: true,
Optional: true,
Expand Down

0 comments on commit 188ffef

Please sign in to comment.