Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: surround agentTokenToLogger with mutex #16

Merged
merged 3 commits into from
Feb 15, 2024
Merged

fix: surround agentTokenToLogger with mutex #16

merged 3 commits into from
Feb 15, 2024

Commits on Feb 15, 2024

  1. fix: surround agentTokenToLogger with mutex 

    Fixes #15
    @kylecarbs @sreya
    kylecarbs authored and sreya committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d8175a6 View commit details
    Browse the repository at this point in the history

  2. remove deadlock

    @sreya
    sreya committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f35ece5 View commit details
    Browse the repository at this point in the history

  3. fix: avoid calling sendLog in a goroutine on a closed logger 

    - Calling p.sendLog in a goroutine allows the goroutine to escape
  the mutex that is being held by a calling function, presenting
  an opportunity for concurrent read/writes to occur on the map.
    @sreya
    sreya committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6dd42ba View commit details
    Browse the repository at this point in the history