Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --font-size & --fixed-font-size flags #11

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

d3cryptofc
Copy link
Contributor

@d3cryptofc d3cryptofc commented Sep 27, 2024

$ ./hyprnotify --help

DBus Implementation of Freedesktop Notification spec for 'hyprctl notify'

Usage:
  hyprnotify [flags]

Flags:
      --fixed-font-size   makes font size fixed, ignoring new sizes
  -f, --font-size uint8   set default font size (range 1-255) (default 13)
  -h, --help              help for hyprnotify
  -s, --no-sound          disable sound, silent mode

My motivation for this PR is that the default font size is very small, this flag not only solves my problem but also makes the size fixed.

Video demo:
https://github.com/user-attachments/assets/bd6a5e4a-6f1d-45eb-9b21-e7d49eb1e70a

@codelif
Copy link
Owner

codelif commented Sep 27, 2024

bro's back to back 🔥

@codelif
Copy link
Owner

codelif commented Sep 27, 2024

the fixed size behaviour of the font-size flag is kinda ambiguous imo.

I think a separate flag for fixed size would be better.

@d3cryptofc
Copy link
Contributor Author

d3cryptofc commented Sep 27, 2024

I don't know if I understand. Are you suggesting that I should rename the flag to --fixed-font-size?

or are you saying there should be a --font-size to set a default size and a --fixed-font to make the default size fixed?

@codelif
Copy link
Owner

codelif commented Sep 27, 2024

Are you suggesting that I should rename the flag to --fixed-font-size?

That will work as well.

I was thinking of separating this into two different flags, one option --font-size which just sets the font size and the other just a flag --fixed-font-size, which will lock the font size.

But that can be done later, for now renaming this to --fixed-font-size should make it less ambiguous for its function.

@codelif
Copy link
Owner

codelif commented Sep 27, 2024

or are you saying there should be a --font-size to set a default size and a --fixed-font to make the default size fixed?

Yes.

@d3cryptofc
Copy link
Contributor Author

But that can be done later, for now renaming this to --fixed-font-size should make it less ambiguous for its function.

I already have both flags ready, would you like me to add both to this PR?

Flags:
      --fixed-font-size   makes font size fixed, ignoring new sizes
  -f, --font-size uint8   set default font size (range 1-255) (default 13)
  -h, --help              help for hyprnotify
  -s, --no-sound          disable sound, silent mode

@codelif
Copy link
Owner

codelif commented Sep 27, 2024

But that can be done later, for now renaming this to --fixed-font-size should make it less ambiguous for its function.

I already have both flags ready, would you like me to add both to this PR?

Flags:
      --fixed-font-size   makes font size fixed, ignoring new sizes
  -f, --font-size uint8   set default font size (range 1-255) (default 13)
  -h, --help              help for hyprnotify
  -s, --no-sound          disable sound, silent mode

I forgot dude's a 10x.

For sure add them lol.

@d3cryptofc d3cryptofc changed the title feat: add flag --font-size to set a fixed font size feat: add --font-size & --fixed-font-size flags Sep 27, 2024
set default font size (range 1-255) (default 13)
makes font size fixed, ignoring new sizes
@d3cryptofc
Copy link
Contributor Author

By the way, when will the next release be released on AUR?

@codelif
Copy link
Owner

codelif commented Sep 27, 2024

when you stop sending PRs. (jk)

after this probably. haven't had the time to properly document all the changes, tomorrow's saturday, so will wrap up a new release.

@d3cryptofc
Copy link
Contributor Author

Nice. I think I've exhausted all the ideas I had with this last PR, I can officially abandon other notification daemons! Simply sensational project, congratulations on the great idea.

@codelif
Copy link
Owner

codelif commented Sep 27, 2024

Thank YOU dude. For bringing light to a half-abandoned project. This probably would have been on the shelf for another 6 months, had you not come.

Credit goes to you. 👏👏👏

@codelif
Copy link
Owner

codelif commented Sep 29, 2024

It seems my laptop has decided to break down, the releases might take a while. (since my laptop has all the AUR ssh keys)

merging this meanwhile.

(sorry for the delay ; 😞

@codelif codelif merged commit f13a3d8 into codelif:main Sep 29, 2024
1 check passed
@d3cryptofc
Copy link
Contributor Author

Too bad, I'm sorry about your laptop 😔
But don't worry, in the meantime I'll be using the locally built binary.

Thanks for letting me know, boss 🫡

@codelif
Copy link
Owner

codelif commented Sep 30, 2024

salvaged a laptop, so the release has been published and the AUR package has been updated as well.

Also, @Bloeckchengrafik , will the nixos package be updated automatically? if not could you update it aswell?

@Bloeckchengrafik
Copy link
Contributor

will do it later today

@Bloeckchengrafik
Copy link
Contributor

See NixOS/nixpkgs#345485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants