-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use cobra
library instead of flag
#10
Conversation
This library will replace the previous `flag` library, making it more practical to use, including when creating aliases.
See more details on previous commit.
dude you are on fire 🔥 |
I'm tired of Mako and Dunst, when I found this project I almost died of happiness haha |
No it's not a boring situation. Infact it might make #6 easier to implement. |
gosh, hats off to the 10x dev. Made my day. |
Is there anything missing from this PR? |
see the review, also the automatic builds are failing for some reason I am too tired to look into it because it's 3:30 AM rn. Will look into it tomorrow (as in the tomorrow I will wake up into) |
OK. By the way, sorry, I forgot about the time zone, here in my country it has just fallen dusk. |
cmd/hyprnotify/main.go
Outdated
|
||
internal.InitDBus(enableSound) | ||
CmdFlags.BoolVarP(&enableSound, "no-sound", "s", false, "disable sound, silent mode") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this reverses the enableSound
condition, so setting the --no-sound
flag actually enables sound and vice versa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied the original, how strange is that..
https://github.com/codelif/hyprnotify/blob/main/cmd/hyprnotify/main.go#L12-L14
and I thought there was no sound due to some lack of dependence 🤔
Edit 2:
It seems that in version 7.0 it was correct:
https://github.com/codelif/hyprnotify/blob/v0.7.0/cmd/hyprnotify/main.go#L9-L16
But in the future it was reversed in this commit:
I will make the correction commit.
btw I fixed the failing builds, it was using an older version of a action. teehee |
LGTM! Kudos to you. |
I'm suggesting this PR for the following reasons:
--font-size
to define a fixed size for the font, and this library would make reading much more pleasant. (In fact, I already have the code ready and working, but I still need to organize the commits)I know it's a boring situation but I ask you to think about it, I think it's worth it. Thank you!